Bug #261

job-generator fails to add shell.command if you use an invalid variable name/forget to escape variables

Added by Simon Schulz over 10 years ago. Updated about 9 years ago.

Status:ResolvedStart date:2014-05-28
Priority:NormalDue date:
Assignee:Jan Moringen% Done:

100%

Category:build-generatorSpent time:-
Target version:-

Description

there seems to be a bug within the job generator when there are invalid escape sequences.

example 1:

"shell.command" : "echo  \"#pkg config file for reflexxes lib\nprefix=${toolkit.dir}\nexec_prefix=\\${prefix}\nlibdir=\\$(prefix)/lib\nincludedir=\\$(prefix)/include\nName: reflexxes\nDescription: reflexxes motion lib\nVersion: 1.2.3\nRequires:\nLibs: -L\\${libdir} -lReflexxesTypeII\nCflags: -I\\${includedir}\n\n\" 

-> the shell commands are added to the jenkins job as expected.

example 2:

"shell.command" : "echo  \"#pkg config file for reflexxes lib\nprefix=${toolkit.dir}\nexec_prefix=\\${prefix}\nlibdir=\\$(prefix)/lib\nincludedir=\\$(prefix)/include\nName: reflexxes\nDescription: reflexxes motion lib\nVersion: 1.2.3\nRequires:\nLibs: -L\\${libdir} -lReflexxesTypeII\nCflags: -I${includedir}\n\n\" 

DIFFERENCE: -I${includedir} instead of -I\\${includedir} (a typo..)

i do not get any warning or error. the full shell.command is simply ignored and does not show up in jenkins config.xml


Related issues

duplicated by Cognitive Interaction Toolkit - Bug #335: errors with environment variables are not reported Closed 2014-11-21
duplicated by Cognitive Interaction Toolkit - Bug #354: poor / no error feedback of build-generator Closed 2014-12-17

Associated revisions

Revision ca814051
Added by Jan Moringen about 9 years ago

Adapted templates for strict generator version in templates/*/*.template

refs #261

  • templates/*/*.template: provide empty default values for potentially
    undefined variables to enable signaling errors on undefined variables

History

#2 Updated by Florian Lier about 9 years ago

  • Status changed from New to Feedback

Status?

#3 Updated by Jan Moringen about 9 years ago

  • Category set to build-generator
  • Status changed from Feedback to Resolved
  • Assignee set to Jan Moringen
  • % Done changed from 0 to 100

Should be fixed in master version.

Also available in: Atom PDF