Bug #261
job-generator fails to add shell.command if you use an invalid variable name/forget to escape variables
Status: | Resolved | Start date: | 2014-05-28 | |
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | Jan Moringen | % Done: | 100% | |
Category: | build-generator | Spent time: | - | |
Target version: | - |
Description
there seems to be a bug within the job generator when there are invalid escape sequences.
example 1:
"shell.command" : "echo \"#pkg config file for reflexxes lib\nprefix=${toolkit.dir}\nexec_prefix=\\${prefix}\nlibdir=\\$(prefix)/lib\nincludedir=\\$(prefix)/include\nName: reflexxes\nDescription: reflexxes motion lib\nVersion: 1.2.3\nRequires:\nLibs: -L\\${libdir} -lReflexxesTypeII\nCflags: -I\\${includedir}\n\n\"
-> the shell commands are added to the jenkins job as expected.
example 2:
"shell.command" : "echo \"#pkg config file for reflexxes lib\nprefix=${toolkit.dir}\nexec_prefix=\\${prefix}\nlibdir=\\$(prefix)/lib\nincludedir=\\$(prefix)/include\nName: reflexxes\nDescription: reflexxes motion lib\nVersion: 1.2.3\nRequires:\nLibs: -L\\${libdir} -lReflexxesTypeII\nCflags: -I${includedir}\n\n\"
DIFFERENCE: -I${includedir} instead of -I\\${includedir} (a typo..)
i do not get any warning or error. the full shell.command is simply ignored and does not show up in jenkins config.xml
Related issues
Associated revisions
Adapted templates for strict generator version in templates/*/*.template
refs #261
- templates/*/*.template: provide empty default values for potentially
undefined variables to enable signaling errors on undefined variables
History
#1 Updated by Jan Moringen over 10 years ago
See upstream issue https://code.cor-lab.org/issues/1892.
#3 Updated by Jan Moringen about 9 years ago
- Category set to build-generator
- Status changed from Feedback to Resolved
- Assignee set to Jan Moringen
- % Done changed from 0 to 100
Should be fixed in master version.