Bug #416

JSON validation bug causes "versions" to be ignored

Added by Lars Schillingmann over 9 years ago. Updated about 9 years ago.

Status:RejectedStart date:2015-08-12
Priority:NormalDue date:
Assignee:Lars Schillingmann% Done:

0%

Category:build-generatorSpent time:-
Target version:-

Description

{
   "name":"ffmpeg-stable",
   "catalogue.system.nid":"0",
   "catalogue.system.title":"ffmpeg",
   "catalogue.system.version.nid":"0",
   "catalogue.system.version.title":"stable-latest",
   "variables":{
      "toolkit.volume":"/tmp/",
      "toolkit.dir":"${toolkit.volume}/${distribution-name}",
      "buildflow-name":"distribution-buildflow-${distribution-name}",
      "finish-hook-name":"distribution-finish-${distribution-name}",
      "prepare-hook-name":"distribution-prepare-${distribution-name}",
      "recipe.maintainer":[
         "lschilli@techfak.uni-bielefeld.de" 
      ],
      "access":"private",
      "platform-requires":{
         "ubuntu":{  
         "packages": [
                    "cmake", "build-essential" 
                ]
            }
         }
      },
      "prepare-hook/unix":"mkdir -p \"${toolkit.dir}\" chmod 2755 \"${toolkit.dir}\"",
      "finish-hook/unix":"find \"${toolkit.dir}\" -type d -exec chmod 2755 {} \\; find \"${toolkit.dir}\" -type f -exec chmod go+r {} \\; find \"${toolkit.dir}\" -type f -perm /100 -exec chmod go+x {} \\; chmod -R g+x \"${toolkit.dir}\"/bin",
      }
   "versions": [
      [
         "ffmpeg",
         "master" 
      ]
   ]
}

History

#1 Updated by Johannes Wienke over 9 years ago

??? What is happening and what is expected?

In any case, the versions list does not contain entries of the form ["project", "project-version"]. It does, it is just unusually formatted...

#2 Updated by Lars Schillingmann over 9 years ago

The JSON is not valid. It is expected that the build-generator is able to detect invalid JSON and reject it. Instead parts of the JSON file are ignored, leading to the ffmpeg job not being created.

#3 Updated by Jan Moringen over 9 years ago

Lars Schillingmann wrote:

The JSON is not valid.

  "finish-hook/unix":"…",
}                       ^ illegal comma
 ^ missing comma
"versions": [

You mean this syntax error, right?

It is expected that the build-generator is able to detect invalid JSON and reject it.

It should do exactly that. How do you invoke the generator and what is the complete output (to std{out,err})?

#4 Updated by Jan Moringen about 9 years ago

  • Category set to build-generator
  • Status changed from New to Feedback
  • Assignee changed from Jan Moringen to Lars Schillingmann

Taking the clarification into account, do you still observe incorrect behavior of the generator?

#5 Updated by Jan Moringen about 9 years ago

  • Status changed from Feedback to Rejected

Please reopen as necessary.

Also available in: Atom PDF